Elektrine lite

← Feed

@JordanZ@lemmy.world

2026-09-12 04:51 UTC

I honestly wish for a PR this size. One of the ones that came across this week was 813 commits, +17K -2K. Of the 250 commits that GitHub was willing to show it had 35 other PRs merged into this massive one. Why they thought one giant PR was somehow better I’ll never know. Of course…high priority, please review and merge immediately. Like guys it’s gonna take me a week to make sense of this.

Replies (5)

  • @ragas@lemmy.ml 2026-09-12 05:41

    Lol nothing bigger than 250 lines of code goes through at our company without complaints.

    Open ##4674659

  • The review process is all wrong if something like this is ever on the table as a single PR. Big changes like this were made before, and knowing how to split the work (or at least trying to work it out) used to be part of the job. Hopefully, strong unions and worker involvement can remedy this, given we change our work culture to be closer to what projects like SQLITE and FFMPEG have (noting, of course, the fact these are FOSS, and made by volunteers, yet are very dependable), slower and stable development cycle that prioritizes high quality work that people can actually depend on and trust.

    Open ##4674722

  • > 1k lines = LGTM

    Open ##4674859

  • Jeez. Now I feel bad. I’ve been working on a project with some new people, and I’ve never used Github before. I’m still learning the etiquette. I made a branch, and spent a month viciously hunting every bug I could find. I don’t trust AI, so I was doing it all by hand. Dawn to dusk, I was staring at code and typing like I had a fever and the only cure was figuring out where tf that invalid scope is supposed to go. This is my first real project with other people, so of course I’m so proud when I send the PR and it has 40,000 lines added and 60,000 lines removed. It was almost all bug fixes, the actual new stuff was about 1,000 or so lines. But what should I do in the future? I don’t wanna be an asshole, I wanna be helpful.

    Open ##4676154

  • @mattreb@feddit.it 2026-09-13 15:53

    If you can digest a 17k lines of code from someone else in 1 week you’re either delusional or a beautiful mind, I would close such PR immediately but it would still ruin my day

    Open ##4681864