2026-09-12 11:03 UTC
Replies (3)
-
@getFrog@piefed.social 2026-09-12 11:40
Stupid question, but what happens to a rejected PR? Because features get built for a reason (there’s usually a Ticket/Story for the feature that the PR adds) so do those just get closed? Or does the person have to re-write the code entirely? I know in my team, the most I could do is tell the coworker to self-review while keeping the PR open until they change some stuff. I have never rejected a PR before because no matter how bad a PR is, it always is technically necessary for the feature.
-
@Pika@sh.itjust.works 2026-09-12 12:25
is it auto reject, or just doesn’t auto approve and leaves it open. It seems weird that you can’t do a pr at all with 1000 line changes, any moderate size feature additional could hit that mark
-
@victorz@lemmy.world 2026-09-12 13:14
What if you remove some files? 🙃